Skip to content

Remove performance module string translations and updated language files #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

Remove performance module string translations and updated language files #968

merged 1 commit into from
Mar 13, 2025

Conversation

geckod22
Copy link
Contributor

@geckod22 geckod22 commented Mar 5, 2025

Proposed changes

This PR is to remove the Performance Module strings from the plugin as now they are managed by the module itself since version 2.7.0

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@cypress Cypress
Copy link

cypress bot commented Mar 5, 2025 •
edited
Loading

HostGator Plugin    Run #5908

Run Properties:  status check passed Passed #5908  •  git commit 3120e74db7 ℹ️: Merge 60443a835892e58dc9790dd4386ba9e0144bc204 into 72d1bc6fd545fef401ab10318c87...
Project HostGator Plugin
Branch Review PRESS7-198-remove-performance-module-strings-translation
Run status status check passed Passed #5908
Run duration 29m 18s
Commit git commit 3120e74db7 ℹ️: Merge 60443a835892e58dc9790dd4386ba9e0144bc204 into 72d1bc6fd545fef401ab10318c87...
Committer Armando Liccardo
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 29
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 314
View all changes introduced in this branch ↗︎

@circlecube circlecube added this to the March 12, 2025 Release milestone Mar 5, 2025
@circlecube circlecube changed the base branch from main to develop March 12, 2025 17:49
@circlecube circlecube merged commit b0e74ee into develop Mar 13, 2025
22 checks passed
@circlecube circlecube deleted the PRESS7-198-remove-performance-module-strings-translation branch March 13, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@circlecube circlecube circlecube approved these changes

@arunshenoy99 arunshenoy99 Awaiting requested review from arunshenoy99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
March 19, 2025 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@geckod22 @circlecube